Skip to content
This repository has been archived by the owner on Sep 12, 2021. It is now read-only.

Update GitHubProvider to send token via header #576

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

stringbean
Copy link
Contributor

@stringbean stringbean commented Feb 5, 2020

Pull Request Checklist

Purpose

Updates GitHubProvider to send the OAuth2 token via an authorization header instead of a query param. This is needed as GitHub have deprecated the query param mechanism and are notifying API users periodically about this.

Note: this might be a breaking change for any users that have overridden the GitHub URL.

Background Context

Based the changes on the Dropbox provider which also sends via a header.

References

  • GitHub Developer blog post discussing the deprecation.

@stringbean
Copy link
Contributor Author

I'll also raise a PR against minutemen/silhouette with the same changes.

@coveralls
Copy link

coveralls commented Feb 5, 2020

Coverage Status

Coverage increased (+0.08%) to 95.909% when pulling 8f27411 on stringbean:github-oauth-header into 1d6defb on mohiva:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 95.763% when pulling 8f27411 on stringbean:github-oauth-header into 1d6defb on mohiva:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 95.763% when pulling 8f27411 on stringbean:github-oauth-header into 1d6defb on mohiva:master.

@akkie akkie merged commit 2c94117 into mohiva:master Feb 10, 2020
@akkie
Copy link
Contributor

akkie commented Feb 10, 2020

@stringbean Many thanks 👍 . Will be released with the next Silhouette version targeting Play 2.8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants