#228: Declare dependency on json4s optional #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeltz
requested review from
lxwbr,
HerrSchwarz,
AlexWerff,
JonasAckermann,
willbinzi,
KCala,
houcros and
m-dobler
as code owners
houcros
approved these changes
Mar 1, 2023
|
Just came to my mind: would it be worth updating the README? Because in this new version, a user would have to add a dependency to |
|
Generally a good idea but where would you add it? The documentation doesn't mention JSON at all anywhere. |
|
Ah I see, in that case it's unlikely anyone will miss those JSON methods. I had thought they were part of the main API somehow. |
|
Hmm hmm, I think not mentioning it would still be a footgun :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declares the dependency on
json4sas optional. Consumers of this library need to add the dependency to their project to be able to use theVersionedModelReader.fromJsonandVersionedModelWriter.toJson.Fixes #228.
Has the version number been increased?