Forbid mutating procs for types with ro pragma.
#126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks almost perfect!
Could the pragma have a human readable name, e.g. "readOnly", similar to how you have the tableName pragma?
I know that ro stands for read-only right now since I know the context, but I had never seen that acronym in use before so I assume I'd likely find myself confused by it in 6 months (or somebody that doesn't know the context wouldn't be certain at a glance what the ro stands for)
|
The only reason I use ro here is because it already exists :-) However, I'm ok to deprecate ro in favor of readOnly. |
|
Imo it's better to do the pragma renaming in a separate PR. This one is about this one feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.