updated xstatic-font-awesome #1326
Comments
|
@ThomasWaldmann could you create from this a new pypi package? Or add me as maintainer. |
|
@ReimarBauer Sure, I just invited you to the pypi project, so you can help. Thanks! |
|
https://github.com/python-xstatic Not sure why I created 2 orgs... And there is also the stuff at https://github.com/openstack ... @ReimarBauer @deshipu guess we should only have 1 org. any preference about which one? |
|
I asked first in the openstack because I thought it is an easy task openstack-archive/xstatic-font-awesome#2 not knowing that the one I asked don't be responsible. He mentioned there are more maintainers. there it is This has compared to the old one a lot more data and I do use There was also a name change I would prefer https://github.com/xstatic-py We should also think about if we can copy some ideas from conda-forge, especially the one which creates pull requests for the recipe when the source gets a new release. I find it useful for the packages not to establish a complex collaboration processes, since we are only building a meta layer, the code is from someone else. |
|
@ThomasWaldmann sorry for the delay, I was on holidays. There seems to be a bit more of a mess with this. Since some of the xstatic packages that we used in Horizon seemed to be unmaintained, and there were no repositories on github for them, we adopted them into the openstack organization. But suddenly you are making a release, with changes that break horizon, in the middle of holidays, ignoring the openstack release process. That got some people concerned. So I would love to clarify the ownership of those packages, as well as the correct repositories for them (the pypi page lists the fontawesome repository as the project's repository, which seems wrong). |
|
@deshipu sorry if i broke something (what package/what release was it?). I wasn't aware of any "openstack release process". If horizon has very strict requirements and installs dependencies automatically, it maybe make sense if you pin versions there, so that newer versions only get installed after some developer tested them. |
|
No harm done, it just made some people worried. We pinned the version and all is good. It was the font-awesome one. If it's going to live under the xstatic repository, I'm going to ask to remove it form under the openstack care. If possible, I would like to review the other xstatic packages, to make sure everyone are on the same page about where they belong. I will prepare a list tomorrow. |
|
@deshipu me was that culprit. I did run in the problem that this and some other packages seems not been updated since long. This version was required essential for me. That gh was used https://github.com/ReimarBauer/xstatic-font-awesome I also don't pin all packages, sometimes it would help, sometimes the problem arises in some underlaying library. We had also trouble over the holidays. We should get to a state that packages can get updates. |
|
Let's just clarify where everything belongs, and add proper links to the correct repositories on pypi, this should resolve most of the problems. We will make sure that only openstackci is a maintainer on those projects that remain under OpenStack, so that the release process will be enforced on those. |
|
just looked into the web interface and have not seen an option to change links there. I do tommorrow a new upload, and remove that tox.ini which was leftover. |
|
I think it's defined in the project.toml: https://github.com/ReimarBauer/xstatic-font-awesome/blob/master/pyproject.toml#L27-L30 |
|
yes, and that will update the pypi server on a new build there. In the past I think we could alter meta data also in the webfrontend. |
|
That repository entry is neat, compared to some other older packages, e.g. https://pypi.org/project/XStatic-Pygments/ Once you accept that you need tomls that change is a good improvement. |
|
Here is the list of xstatic packages that got adopted into the OpenStack repositories:
If you would like to maintain any of them outside of OpenStack, we can remove them from our repositories. For the ones that remain, I would like to remove any maintainers other than openstackci from their PyPi pages, so that releases can only be done through the OpenStack release process. Would that work for you? What do you think? |
|
As long as a selection is only used by OpenStack, no problem occurs. How do we handle this if someone needs an update "tomorrow"? Can we then successively move the package? The reverse is the same if a single maintainer does not respond to an upgrade request. I would like to put everything I do for my projects in a github organization. My pinning looks like this now XStatic-jQuery==3.5.1.1 |
|
MoinMoin has |
|
So it looks like only xstatic-font-awesome and xstatic-jquery.tablesorter are shared. Would the MoinMoin project be happy to maintain those two packages, following its own contribution guidelines? We can then remove them from our repositories. As for OpenStack contribution process, it's described in excruciating detail at https://docs.openstack.org/contributors/code-and-documentation/index.html, but in short you submit a patch to the project's gerrit, where it is reviewed by other developers and merged if it gets at least two +2 votes. If a version number was incremented, a release is made automatically by our continuous integration scripts. Only members of the project's core developers team can give +2 votes, and new members are added by the existing members based on contributions. |
|
I do agree to this. @ThomasWaldmann and @RogerHaase fine for you too? |
|
OK with me
…On Thu, Jan 12, 2023 at 10:31 AM ReimarBauer ***@***.***> wrote:
I do agree to this. @ThomasWaldmann <https://github.com/ThomasWaldmann>
and @RogerHaase <https://github.com/RogerHaase> fine for you too?
—
Reply to this email directly, view it on GitHub
<#1326 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGODHTPM4J4Q6ZENLQ44S3WSA5XZANCNFSM6AAAAAATG2RZBM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
guess i will rarely contribute, so choose whatever works best for you all. just as a side note: compared to the "ease of use" and widespreadness of github (people having accounts, familiarity with PR process, etc), IMHO that openstack contribution process might be rather repelling (or at least not attracting) outside contributions. |
Update FontAwesome macro and moinwiki rst docs for FontAwesome 6, #1326
|
Hi @ReimarBauer hope you are doing well, I was about to retire the "xstatic-font-awesome" repo from OpenStack tree but Can you please clarify the URL for xstatic-font-awesome and xstatic-jquery.tablesorter repos where you are going to maintain it. I will update the same URL in |
|
@ReimarBauer One correction here, want to know about Xstatic-jquery-ui repo URL not xstatic-jquery.tablesorter. |
|
Hi @manchandavishal, mostly fine. Currently fixing things after setuptools changes ;) xstatic-font-awesome, this will get soon a new build, we take care for it in https://github.com/xstatic-py/xstatic-font-awesome. Also the other one will be done in the https://github.com/xstatic-py organisation. I will not do this packaging community work in a user repo. |
|
@ReimarBauer ok, gotcha. thanks for the quick response. |
|
Btw. do you be on FOSDEM meetup? |
|
No. |
|
So here we are :) and first time we have a xstatic- repository link in the upload.
|
|
What about the |
|
Lets have a look on the state of that. in 2020 there was v2.31.3 the last release https://github.com/Mottie/tablesorter/tags It may need more people to help It blocks currently support for JQuery 3.6.0 When someone at OpenStack does a v2.31.3 xstatic package I fear this will stay for long. Or we find someone who refactors it for JQuery 3.6.0. So yes I am happy it stays at OpenStack. |
|
@ReimarBauer are you ok with maintaining "xstatic-jquery" like you are doing for xstatic-jquery_ui and xstatic-font-awesome ? |
|
@manchandavishal I do. This is also our example for XStatic itselfs. This will also get the repository url. |
|
@ReimarBauer ok thanks for confirming, we are retiring xstatic-jquery_ui, xstatic-font-awesome and xstatic-jquery packages from OpenStack and going to use them from https://github.com/xstatic-py. |
|
@manchandavishal when you update, or do new packages would you so kind also add this repository url? I think this is much easier to see for new users how and who is helping with these packages. |
|
@ReimarBauer yeah I will update repository URL in |
|
@deshipu What was wrong with me as maintainer of that package https://pypi.org/project/XStatic-Font-Awesome/ ? |
|
@manchandavishal I thought we agreed to maintain this package under the xtatic-py organization, just got a mail that I was removed from https://pypi.org/project/XStatic-Font-Awesome/ |
|
Ouch, that is my mistake. I will work on putting the maintainers back, sorry about this. I was removing the maintainers from other pypi projects, and included this project by mistake. |
|
I put everyone back, sorry for the problem again. |
|
@ThomasWaldmann @deshipu do you have interest do become a maintainer role for that package on conda-forge too? I currently prepare that. |
xstatic-angular-fileupload pypi is used by Horizon. Horizon team discussed this topic in the horizon weekly meeting and decided to move it under the horizon deliverables and keep them under the OpenStack namespace [1]. We also check with moinwiki contributor and they are not using this pypi project [2]. [1] https://meetings.opendev.org/irclogs/%23openstack-horizon/%23openstack-horizon.2023-02-01.log.html#t2023-02-01T16:09:57 [2] moinwiki/moin#1326 (comment) Needed-By: https://review.opendev.org/c/openstack/project-config/+/873843 Change-Id: I8a1c1afdad7f2768e80c1efc5cdbcd914abc8e71
Hi,
I had to update a xstatic package, and added there a toml definition too.
Take it as an example if needed
https://github.com/ReimarBauer/xstatic-font-awesome
greetings
Reimar
The text was updated successfully, but these errors were encountered: