fix TiDB DEFAULT_GENERATED #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ming535
reviewed
Jun 29, 2020
| if extra.Valid && strings.Contains(strings.ToUpper(extra.String), "GENERATED") { | ||
|
|
||
| // TiDB describes certain column as `DEFAULT_GENERATED` | ||
| if extra.Valid && (strings.Contains(strings.ToUpper(extra.String), "VIRTUAL GENERATED") || |
There was a problem hiding this comment.
better to cache the result of "IsTidb" , and use that to identiry tidb.
There was a problem hiding this comment.
IsTiDB does not help here.
It distinguishes whether a column is generated or not, rather than TiDB or not.
ming535
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this closes #289
for datetime column with
DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMPproperty, TiDB show it asDEFAULT_GENERATED on update CURRENT_TIMESTAMPin meta data. There might be other cases I'm not sure but anyway it must be distinguished from MySQLSTORED GENERATEDandVIRTUAL GENERATEDcolumns.