move test GetTriggerURI pushover_test.go -> datatypes_test.go

moira-alert · Feb 11, 2019 · 1383256 · 1383256
1 parent 6b9acde
commit 1383256
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 20 deletions.
diff --git a/datatypes_test.go b/datatypes_test.go
@@ -474,3 +474,19 @@ func TestSubscriptionData_MustIgnore(testing *testing.T) {
 		}
 	})
 }
+func TestBuildTriggerURL(t *testing.T) {
+	Convey("Sender has no moira uri", t, func() {
+		url := TriggerData{ID: "SomeID"}.GetTriggerURI("")
+		So(url, ShouldResemble, "/trigger/SomeID")
+	})
+
+	Convey("Sender uri", t, func() {
+		url := TriggerData{ID: "SomeID"}.GetTriggerURI("https://my-moira.com")
+		So(url, ShouldResemble, "https://my-moira.com/trigger/SomeID")
+	})
+
+	Convey("Empty trigger", t, func() {
+		url := TriggerData{}.GetTriggerURI("https://my-moira.com")
+		So(url, ShouldBeEmpty)
+	})
+}
diff --git a/senders/pushover/pushover_test.go b/senders/pushover/pushover_test.go
@@ -138,26 +138,6 @@ func TestBuildTitle(t *testing.T) {
 	})
 }
 
-func TestBuildTriggerURL(t *testing.T) {
-	sender := Sender{}
-	Convey("Sender has no moira uri", t, func() {
-		url := moira.TriggerData{ID: "SomeID"}.GetTriggerURI(sender.frontURI)
-		So(url, ShouldResemble, "/trigger/SomeID")
-	})
-
-	Convey("Sender uri", t, func() {
-		sender.frontURI = "https://my-moira.com"
-		url := moira.TriggerData{ID: "SomeID"}.GetTriggerURI(sender.frontURI)
-		So(url, ShouldResemble, "https://my-moira.com/trigger/SomeID")
-	})
-
-	Convey("Empty trigger", t, func() {
-		sender.frontURI = "https://my-moira.com"
-		url := moira.TriggerData{}.GetTriggerURI(sender.frontURI)
-		So(url, ShouldNotResemble, "https://my-moira.com/trigger/")
-	})
-}
-
 func TestMakePushoverMessage(t *testing.T) {
 	location, _ := time.LoadLocation("UTC")
 	logger, _ := logging.ConfigureLog("stdout", "debug", "test")