fix http schema escaping when build url in webhook sender

senders/webhook/request.go

@@ -68,7 +68,12 @@ func buildRequestURL(template string, trigger moira.TriggerData, contact moira.C
 		moira.VariableTriggerID:    trigger.ID,
 	}
 	for k, v := range templateVariables {
-		template = strings.Replace(template, k, url.PathEscape(v), -1)
+		value := url.PathEscape(v)
+		if k == moira.VariableContactValue &&
+			(strings.HasPrefix(v, "http:/") || strings.HasPrefix(v, "https://")) {
+			value = v
+		}
+		template = strings.Replace(template, k, value, -1)
 	}
 	return template
 }

senders/webhook/request_test.go

@@ -213,6 +213,21 @@ func TestBuildRequestURL(t *testing.T) {
 	})
 }
 
+var testContactWithUrl = moira.ContactData{
+	ID:    "contactID",
+	Type:  "contactType",
+	Value: "https://test/moirahook",
+	User:  "contactUser",
+	Team:  "contactTeam",
+}
+
+func TestBuildRequestURL_FromContactValueWithURL(t *testing.T) {
+	Convey("URL should contain variables values", t, func() {
+		actual := buildRequestURL("${contact_value}", testTrigger, testContactWithUrl)
+		So(actual, ShouldEqual, "https://test/moirahook")
+	})
+}
+
 func prepareStrings(actual, expected string) (string, string) {
 	return strings.Join(strings.Fields(actual), ""), strings.Join(strings.Fields(expected), "")
 }