Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.4.0 #160

Merged
merged 65 commits into from
Dec 25, 2018
Merged

Release 2.4.0 #160

merged 65 commits into from
Dec 25, 2018

Conversation

borovskyav
Copy link
Contributor


Important! Redis DB conversion is required.

Moira 2.4 has some structure changes in Redis DB. It will work fluently out of the box, but lazy triggers will still be checked every time on new metrics.

You can upgrade from moira 2.2 or 2.3 using corresponding flag in --from-version variable.

moira-cli --config=/etc/moira/cli.yml --update --from-version=2.2/2.3

If you would like to downgrade back to Moira 2.2 or 2.3, you should run CLI-converter.

moira-cli --config=/etc/moira/cli.yml --downgrade --to-version=2.2/2.3

Both cases imply usage of Moira-Cli v.2.4, you can find it on Release Page.

kamaev and others added 30 commits August 24, 2018 17:17
* fix path for kontur senders

* Update registrator.go

* fix default branch value

* Update registrator.go

* added slack notifications

* fix pad

* added travis2travis

* fix git hash
* feature itself

* remove last check key

* Update trigger.go
Trigger metrics are overkill. Nobody ever checks them. Kill and forget.
* What a beautiful code I have here. It would be shame if it doesn't work...

* WTF...

* I think, this hack should work

* I win this round... No NODATA - OK anymore.

* Fix tests

* I ain't the sharpest tool in the shed

* Fix EventTimeStamp in empty lastCheck

* Add new CheckData field, remove duck tape

* Trying to speed up tests

* Refactoring NODATA - OK logic

* Revert "Trying to speed up tests"

This reverts commit cac064b.

* fix bug

* refactor GetOrCreateMetricState method, remove unnecessary assignments

* Add tests
* add new logic

* remove unnecessary logic
…ptions

Trying to make remote triggers exceptions more secure.
* Add new method which deletes all NODATA metrics from trigger.

* add tests

* refactor this
* Fix board cases in schedule

* make it less stupid
* Remove metrics retention values

* Fix redis leakage: remove metrics data for patterns out of use

* Add tests for a new logic

* Add mock generator to repo

* Add new methods in Database interface

* Add lock for NODATA checker, so there are always only one NODATA checker
Let's see what happens

* fix logging

* few fixes

* few fixes

* add tests

* make checks frequently

* move deregister

* Steal Like an Artist 🎨
I just copied test from #128, thanks @kamaev

* add tests
* move subset and leftJoin to `moira → helpers`

* I coded database methods for checking optimizations

* Add worker in checker which updates triggers without subscriptions

* refactor lots of code: names, methods, interfaces

* fix tests

* refactor SaveSubscriptions

* fix tests

* fix linter

* add tests

* fix linter

* add tests

* add tests

* few fixes

* add graphite metrics

* few fixes

* Revert "few fixes"

This reverts commit 077ffbf.

* add tests

* few fixes

* few fixes

* stupid converter for DB. I will fix it in the nearest future in the separate PR

* few fixes

* few fixes
* Add random cache duration for lazy triggers.
So, we evenly spread trigger checks in time.

* Add lazy triggers duration to config

* Fix random duration. Now it relies on config

* Don't start lazy triggers worker if its interval is <= check interval
titusjaka and others added 27 commits December 4, 2018 18:09
I add status for `develop` branch, as it is used as latest actual version of Moira
Refactoring Full-Text-Search index package:
* Fix metric collecting

* Fix log level then fail to save metrics to db
* Add image to Fancy template

* add subscription plotting settings

* show all range

* pass plotting params to notifier

* update senders

* fix problems

* fix tests

* fix tests

* fix tests

* fix tests

* fix tests

* fix tests

* mvp

* log message

* more logging

* hahaha stupid

* refactor

* fix tests

* fix event test

* change slack sender

* update telegram sender

* update mail sender

* refactor

* custom error

* refactor

* refactor

* update slack sender

* update slack sender

* add websocket

* refactor

* test

* refactor

* refactor

* refactor

* refactor

* refactor

* refactor

* refactor

* refactor

* refactor

* fix location usage

* add location to api

* resolve linter warnings

* remove threshold markers, resolve bg padding

* draw all required thresholds in any case

* refactor styles

* refactor time range logic

* fix logging message

* Arkasha loves long strings

* mv ErrNoPointsToRender to renderable

* GetWindow,GetMetricNames,small window log Debug

* set default time range to 30min

* add pushover

* resolve warnings and update pushover

* add subscription settings to cli

* decided not to draw 15mins of nothing

* long lines again

* long lines again

* pretty time ranges

* pretty time ranges

* pretty time ranges

* pretty time ranges

* cli

* fix time ranges

* little fixes
* Add image to Fancy template

* add subscription plotting settings

* show all range

* pass plotting params to notifier

* update senders

* fix problems

* fix tests

* fix tests

* fix tests

* fix tests

* fix tests

* fix tests

* mvp

* log message

* more logging

* hahaha stupid

* refactor

* fix tests

* fix event test

* change slack sender

* update telegram sender

* update mail sender

* refactor

* custom error

* refactor

* refactor

* update slack sender

* update slack sender

* add websocket

* refactor

* test

* refactor

* refactor

* refactor

* refactor

* refactor

* refactor

* refactor

* refactor

* refactor

* fix location usage

* add location to api

* resolve linter warnings

* remove threshold markers, resolve bg padding

* draw all required thresholds in any case

* refactor styles

* refactor time range logic

* fix logging message

* Arkasha loves long strings

* mv ErrNoPointsToRender to renderable

* GetWindow,GetMetricNames,small window log Debug

* set default time range to 30min

* add pushover

* resolve warnings and update pushover

* add subscription settings to cli

* decided not to draw 15mins of nothing

* long lines again

* long lines again

* pretty time ranges

* pretty time ranges

* pretty time ranges

* pretty time ranges

* cli

* fix time ranges

* little fixes

* fix plot adding logic

* fix plot adding logic
* Add API and DB methods for trigger maintenance

* HTTP 299 https://stackoverflow.com/a/29623798

* Fix old tests

* Suppress trigger and metrics events when trigger in maintenance

* Tests for API controller

* Fix linter

* Add DB tests

* Add tests for checker

* Refactoring after review:
1. Remove deprecated DB method
2. Remove redundant casts
3. Log.Debug for new event
4. Few little fixes

* TriggerMaintenance param is pointer now
* Don't save empty tags then save subscription

* Use normalizeTags in trigger save and update
* Forbid user to save subscription with another user contacts

* Fix vetshadow warnings

* go get gomatalinter with update in makefile
…146)

* go get govendor with update flag

* Add DBSource to DbConnector struct and NewDatabase method.

* Update selfStateCheckCountKey if database source only checker

* SelfState update test
…ndor.json (#147)

* Update go to version 1.11.2

* Fix vetshadow warnings

* Update vendor.json

* keeping it simple

* git add -u && git reset vendor/vendor.json

* Update vendor.json
* limit number of series correctly

* fix tests

* fix convey name :)
* always send as moira

* prevent unnecessary api calls
* Fix nil pointer error

* Review fixes, add bad contact ids logic

* Rename error

* Rename again
* extend plot limits

* update test

* rename variable
* added enhancements and tests

* fix tests

* fix tests

* do not resend message hundred times

* go fmt and fix subject state

* ErrEvalExprFailedWithPanic

* ErrEvalExprFailedWithPanic

* rename and add tests
* Update slack.go

* fix slack user

* fix slack user

* fix slack user

* fix slackbot
@borovskyav borovskyav merged commit 8fb1287 into master Dec 25, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 81.765% when pulling a5eb22d on develop into ad04010 on master.

@titusjaka
Copy link
Contributor

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants