feat(checker): Simplify ConvertForCheck function #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In first versions of a new advanced mode after preparation metrics were mixed. In one metrics set there was single and multi metrics targets. Due to this on the step of conversion between map[TargetName]map[MetricName]metrics to map[MetricName]map[TargetName]metrics we had to check if some target is alone metrics target and handle alone metrics targets separately. On the other hand now on the step of preparation all targets are multi metric targets and alone metric targets were filtered on the steps before so we do not need to check alone metrics target on the step of conversion. Relates #428
Codecov Report
@@ Coverage Diff @@
## master #645 +/- ##
==========================================
+ Coverage 69.31% 70.58% +1.27%
==========================================
Files 172 172
Lines 7648 8786 +1138
==========================================
+ Hits 5301 6202 +901
- Misses 2012 2245 +233
- Partials 335 339 +4
Continue to review full report at Codecov.
|
borovskyav
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In first versions of a new advanced mode after preparation metrics were
mixed. In one metrics set there was single and multi metrics targets.
Due to this on the step of conversion between
map[TargetName]map[MetricName]metrics to
map[MetricName]map[TargetName]metrics we had to check if some target is
alone metrics target and handle alone metrics targets separately. On the
other hand now on the step of preparation all targets are multi metric
targets and alone metric targets were filtered on the steps before so
we do not need to check alone metrics target on the step of conversion.
Relates #428