feat(logging) Rename logger functions from <Level>b to <Level> #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #819 +/- ##
==========================================
- Coverage 71.27% 70.32% -0.95%
==========================================
Files 179 179
Lines 9350 9695 +345
==========================================
+ Hits 6664 6818 +154
- Misses 2303 2494 +191
Partials 383 383
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kissken
previously approved these changes
Jan 16, 2023
Dimedrolity
previously approved these changes
Jan 17, 2023
kissken
reviewed
Jan 18, 2023
kissken
reviewed
Jan 18, 2023
| @@ -20,7 +20,7 @@ func GetNotifier(logger moira.Logger, database moira.Database) Heartbeater { | |||
|
|
|||
| func (check notifier) Check(int64) (int64, bool, error) { | |||
| if state, _ := check.db.GetNotifierState(); state != moira.SelfStateOK { | |||
| check.log.Errorb(). | |||
| check.log.Error(). | |||
| String("error", check.GetErrorMessage()). | |||
| Msg("Send message") | |||
There was a problem hiding this comment.
hmm, seems, here should be NOT send, see first issue in new sentry :)
kissken
approved these changes
Jan 25, 2023
Dimedrolity
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.