feat: support sprig library for trigger templates #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kissken
reviewed
Jul 10, 2023
kissken
reviewed
Jul 10, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #876 +/- ##
==========================================
- Coverage 68.38% 68.37% -0.01%
==========================================
Files 187 187
Lines 10335 10332 -3
==========================================
- Hits 7068 7065 -3
Misses 2877 2877
Partials 390 390
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Tetrergeru
reviewed
Jul 12, 2023
Tetrergeru
previously approved these changes
Jul 12, 2023
kissken
reviewed
Jul 12, 2023
|
/build |
Tetrergeru
approved these changes
Jul 13, 2023
kissken
approved these changes
Jul 13, 2023
|
Build and push Docker images with tag: 2023-07-13.f54844f |
1 similar comment
|
Build and push Docker images with tag: 2023-07-13.f54844f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sprig library templates
https://pkg.go.dev/github.com/masterminds/sprig#section-readme
Also filter some functions in sprig to prevent possible unsafety/insecure usages