Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(senders): add GMT to timestamp message in notifier #885

Merged
merged 8 commits into from Aug 3, 2023

Conversation

almostinf
Copy link
Member

Add GMT to timestamp message in notifier

Also fixed corresponding tests

@almostinf almostinf requested a review from a team as a code owner July 26, 2023 06:55
datatypes_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Merging #885 (5ff45cb) into master (96b59d7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5ff45cb differs from pull request most recent head 6d91b1a. Consider uploading reports for the commit 6d91b1a to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #885   +/-   ##
=======================================
  Coverage   68.28%   68.29%           
=======================================
  Files         187      187           
  Lines       10449    10452    +3     
=======================================
+ Hits         7135     7138    +3     
  Misses       2905     2905           
  Partials      409      409           
Files Changed Coverage Δ
datatypes.go 85.15% <100.00%> (+0.19%) ⬆️
senders/discord/send.go 66.66% <100.00%> (ø)
senders/mail/send.go 71.66% <100.00%> (ø)
senders/mattermost/sender.go 90.65% <100.00%> (ø)
senders/msteams/msteams.go 80.45% <100.00%> (ø)
senders/opsgenie/send.go 76.40% <100.00%> (ø)
senders/pagerduty/send.go 72.85% <100.00%> (ø)
senders/pushover/pushover.go 82.19% <100.00%> (ø)
senders/slack/slack.go 61.31% <100.00%> (ø)
senders/telegram/send.go 59.68% <100.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

kissken
kissken previously approved these changes Jul 31, 2023
@almostinf almostinf requested a review from kissken August 3, 2023 09:43
kissken
kissken previously approved these changes Aug 3, 2023
@almostinf almostinf merged commit 267f7f4 into master Aug 3, 2023
5 checks passed
@almostinf almostinf deleted the feature/add-timezone-to-notifier-message branch August 3, 2023 10:45
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Build and push Docker images with tag: 2023-08-03.267f7f4

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Build and push Docker images with tag: 2023-08-03.267f7f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants