Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter): Support wildcards #923

Merged
merged 6 commits into from Oct 5, 2023

Conversation

Tetrergeru
Copy link
Member

@Tetrergeru Tetrergeru commented Sep 27, 2023

Tag filtration worked differently from graphite-clickhouse, so the following change was made:

  • Wildcard support: in seriesByTag('tag=v*') , the star is considered to be a wildcard and the following metrics are matched: name;tag=v.1, name;tag=v_foo e.t.c.

  • Widcard start*finish are interpreted as the the regex ^start.*finish$

by @lordvidex

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Merging #923 (fa5c4af) into master (f919618) will increase coverage by 0.05%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head fa5c4af differs from pull request most recent head 7c7f07f. Consider uploading reports for the commit 7c7f07f to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
+ Coverage   68.85%   68.90%   +0.05%     
==========================================
  Files         196      196              
  Lines       10981    10999      +18     
==========================================
+ Hits         7561     7579      +18     
  Misses       2977     2977              
  Partials      443      443              
Files Coverage Δ
api/controller/trigger.go 77.58% <100.00%> (+1.66%) ⬆️
checker/check.go 84.66% <100.00%> (+0.36%) ⬆️
cmd/cli/cluster.go 63.93% <ø> (ø)
datatypes.go 78.62% <ø> (ø)
filter/series_by_tag.go 95.83% <100.00%> (+0.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Tetrergeru Tetrergeru marked this pull request as ready for review September 27, 2023 12:28
@Tetrergeru Tetrergeru requested a review from a team as a code owner September 27, 2023 12:28
kissken
kissken previously approved these changes Sep 28, 2023
@Tetrergeru
Copy link
Member Author

/build

kissken
kissken previously approved these changes Oct 4, 2023
@Tetrergeru Tetrergeru merged commit 35dafcd into master Oct 5, 2023
6 checks passed
@Tetrergeru Tetrergeru deleted the feature/support-wildcards-in-filter branch October 5, 2023 08:36
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Build and push Docker images with tag: 2023-10-05.35dafcd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants