moira_2.0_support (#2) #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kamaev
commented
Nov 6, 2017
•
kamaev
commented
- Added custom headers support
- Added trigger creation by custom id
- Removed tags extra data addition feature
- Changed ttl type from string to int
- Optimized fetch_by_id for large production solutions
* moira_2.0_fixes_0 * moira_2.0_fixes_1 * moira_2.0_fixes_0_doc * moira_2.0_fixes_3 * moira_2.0_fixes_4 * moira_2.0_fixes_5 * moira_2.0_fixes_6 * moira_2.0_fixes_6 * moira_2.0_fixes_7 * moira_2.0_fixes_7 * moira_2.0_fixes_8 * moira_2.0_fixes_9 * moira_2.0_fixes_1_doc * moira_2.0_fixes_10 * moira_2.0_fixes_1_tags * moira_2.0_fixes_2_doc * moira_2.0_fixes_3_doc * moira_2.0_fixes_4_doc
better example for id field usage
|
Ready for review |
beevee
requested changes
Nov 20, 2017
| @@ -40,7 +40,7 @@ def __init__(self, api_url, login=None, auth_user=None, auth_pass=None): | |||
| if auth_user and auth_pass: | |||
| self.auth = HTTPBasicAuth(auth_user, auth_pass) | |||
|
|
|||
| self.auth_header = {'X-Webauth-User': login} | |||
There was a problem hiding this comment.
А какая причина у этого изменения? У нас же захардкожено в API имя этого заголовка, его нельзя поменять.
moira_client/models/trigger.py
Outdated
| :param ttl_state: str state after ttl seconds without data (one of STATE_* constants) | ||
| :param sched: dict schedule for trigger | ||
| :param expression: str python expression | ||
| :param expression: str golang expression |
There was a problem hiding this comment.
Тут C-like expression лучше написать.
moira_client/models/trigger.py
Outdated
| :param ttl_state: str state after ttl seconds without data (one of STATE_* constants) | ||
| :param sched: dict schedule for trigger | ||
| :param expression: str python expression | ||
| :param expression: str golang expression |
androndo
pushed a commit
to androndo/python-moira-client
that referenced
this pull request
Mar 4, 2021
Add editor settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.