Prevent empty metric summary creation

moira-alert · Apr 4, 2016 · 604415f · 604415f
1 parent 499d3ef
commit 604415f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/static/app/controllers/events.ts b/static/app/controllers/events.ts
@@ -39,9 +39,6 @@ class MetricSummary {
 	list: Array<StateSummary> = [];
 
 	add(event: Event) {
-		if(event.state.name === event.old_state.name){
-			return;
-		}
 		var json = event.json;
 		var old_state_summary = this.states.getOrCreate(json.old_state, new StateSummary(event.old_state, json.timestamp));
 		var state_summary = this.states.getOrCreate(json.state, new StateSummary(event.state, json.timestamp));
@@ -124,6 +121,9 @@ export class EventsController extends GoTo {
 					if (!json.metric) {
 						return;
 					}
+					if(event.state.name === event.old_state.name){
+						return;
+					}
 					$scope.metrics_summary.getOrCreate(json.metric, new MetricSummary()).add(event);
 					var metricEvents = $scope.metrics_history.get(event.metric);
 					if (!metricEvents) {