Small fixes #252
Merged
Small fixes #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borovskyav
changed the title
borovskyav
changed the title
borovskyav
changed the title
sashasushko
suggested changes
Mar 29, 2019
src/Api/MoiraApi.js
Outdated
| @@ -115,7 +115,12 @@ export default class MoiraApi implements IMoiraApi { | |||
| throw new ApiError({ message: errorText, status: response.status }); | |||
| } | |||
| throw new ApiError({ | |||
| message: serverResponse != null ? serverResponse.status : errorText, | |||
| message: | |||
There was a problem hiding this comment.
Можно проще:
serverResponse
? serverResponse.status + (serverResponse.error ? (": " + serverResponse.error) : "")
: errorTextThere was a problem hiding this comment.
Сделал как ты написал, но линтер предложил немного поддругому отформатировать еще
| <div className={cn("tags-menu")} ref={this.tagsRef}> | ||
| <div | ||
| className={cn("tags-menu")} | ||
| style={{ width }} |
There was a problem hiding this comment.
Ок, но эта хуйня выпилена в ветке с поиском
There was a problem hiding this comment.
Мы там в итоге переехали на дефолтный комбобокс?
| @@ -93,6 +93,7 @@ export default function MetricList(props: Props): React.Node { | |||
| </button> | |||
| </div> | |||
| <div className={cn("maintenance")} /> | |||
| <div className={cn("author")} /> | |||
There was a problem hiding this comment.
А это зачем? На списке метрик всё было ок
There was a problem hiding this comment.
Там шапка съехала, из за того что этой колонки не было.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close moira-alert/moira/issues/321