Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] Defer pattern list rendering to improve speed #291

Closed
wants to merge 14 commits into from
Closed

[PERF] Defer pattern list rendering to improve speed #291

wants to merge 14 commits into from

Conversation

idoqo
Copy link

@idoqo idoqo commented Feb 17, 2020

This is for the first Todo item in #286 to make development easier and remove the error from the /patterns page. This is what the patterns page look like now:

Screenshot_2020-02-17 Moira - Patterns

@idoqo idoqo changed the title Add fake data for patterns to db.json WIP: Defer pattern list rendering to improve speed Feb 19, 2020
@idoqo
Copy link
Author

idoqo commented Feb 19, 2020

For the deferred rendering, the parent component is rendered first, and the items are added in steps. I tried using the react-window package and while it is faster, it is harder to use with dynamic heights (we need the height to be dynamic when showInfo is true for a single pattern item). Below are the comparisons for 10,000 patterns:

Current master branch (no deferred rendering)

Screenshot_20200219_231157

With deferred rendering.

Screenshot_20200219_232843

With react-window package

Screenshot_20200219_231003

@idoqo idoqo changed the title WIP: Defer pattern list rendering to improve speed Feature: Defer pattern list rendering to improve speed Feb 19, 2020
@sashasushko
Copy link

@idoqo thanks for pull request. I'll review it at weekend.

@sashasushko
Copy link

@idoqo i don't forgot. A lot of work :-(

@idoqo
Copy link
Author

idoqo commented Feb 24, 2020

@idoqo i don't forgot. A lot of work :-(

😅 Yeah, no problem.

@sashasushko
Copy link

@idoqo can you collaborate with @hv7214 about his PR - #292

Did you affect each other?

@sashasushko sashasushko added the WIP Work in progress label Feb 27, 2020
@idoqo
Copy link
Author

idoqo commented Feb 27, 2020

@idoqo can you collaborate with @hv7214 about his PR - #292

Yes sure!

@hv7214
Copy link
Contributor

hv7214 commented Feb 27, 2020

@sashasushko we had a conversation regarding this, there is only one conflicting file PatternList.jsx so let my PR get merged and then @idoqo will solve conflicts accordingly.

@sashasushko
Copy link

@hv7214 pull request about sorting was merged. @idoqo your turn

@idoqo idoqo changed the title Feature: Defer pattern list rendering to improve speed [PERF] Defer pattern list rendering to improve speed Mar 5, 2020
@sashasushko
Copy link

@idoqo when you finish please tag me and remove WIP badge.

@idoqo
Copy link
Author

idoqo commented Mar 12, 2020

@idoqo when you finish please tag me and remove WIP badge.

Okay @sashasushko, it's ready for review now. I don't have the access to remove the WIP badge though.

@sashasushko sashasushko removed the WIP Work in progress label Mar 12, 2020
@idoqo
Copy link
Author

idoqo commented Apr 16, 2020

Hi @sashasushko, I tried resolving the conflicts between this and master and it affected way more files than I expected. I'm not sure how to resolve that, do you think a new PR would help?

@sol-un sol-un assigned sol-un and unassigned idoqo Oct 26, 2022
@sol-un sol-un removed the request for review from sashasushko October 27, 2022 11:39
@sol-un sol-un closed this Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants