New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PERF] Defer pattern list rendering to improve speed #291
Conversation
For the deferred rendering, the parent component is rendered first, and the items are added in steps. I tried using the react-window package and while it is faster, it is harder to use with dynamic heights (we need the height to be dynamic when Current master branch (no deferred rendering) With deferred rendering. With react-window package |
@idoqo thanks for pull request. I'll review it at weekend. |
@idoqo i don't forgot. A lot of work :-( |
😅 Yeah, no problem. |
@sashasushko we had a conversation regarding this, there is only one conflicting file PatternList.jsx so let my PR get merged and then @idoqo will solve conflicts accordingly. |
@idoqo when you finish please tag me and remove WIP badge. |
Okay @sashasushko, it's ready for review now. I don't have the access to remove the WIP badge though. |
Hi @sashasushko, I tried resolving the conflicts between this and master and it affected way more files than I expected. I'm not sure how to resolve that, do you think a new PR would help? |
This is for the first Todo item in #286 to make development easier and remove the error from the
/patterns
page. This is what the patterns page look like now: