refactor: get available stocks

src/controllers/stock.controller.ts

@@ -1,5 +1,6 @@
 import { Request, Response } from 'express';
 import { StatusCodes } from 'http-status-codes';
+import { RequestExtended } from 'src/interfaces';
 import {
   createOne,
   deleteById,
@@ -12,15 +13,16 @@ import { handleHttpError } from 'src/utils';
 /**
  * Get all stocks.
  *
- * @param _req The request object.
+ * @param req The request object.
  * @param res The response object.
  */
 export const getStocks = async (
-  _req: Request,
+  req: RequestExtended,
   res: Response
 ): Promise<void> => {
   try {
-    const response = await findAll();
+    const { id: userId } = req;
+    const response = await findAll(userId as string);
     res.json(response);
   } catch (error) {
     handleHttpError(res, error);
@@ -34,12 +36,13 @@ export const getStocks = async (
  * @param res The response object.
  */
 export const getStockById = async (
-  req: Request,
+  req: RequestExtended,
   res: Response
 ): Promise<void> => {
   try {
+    const { id: userId } = req;
     const { id } = req.params;
-    const response = await findById(id);
+    const response = await findById(userId as string, id);
     res.json(response);
   } catch (error) {
     handleHttpError(res, error);

src/services/stock.service.ts

@@ -1,38 +1,105 @@
 import { StatusCodes } from 'http-status-codes';
-import { Stock } from 'src/database/models';
-import {
-  IStock,
-  IStockDocument,
-  IStandardResponse,
-} from 'src/interfaces';
+import { Broker, Stock } from 'src/database/models';
+import { IStock, IStockDocument, IStandardResponse } from 'src/interfaces';
 import { HttpError } from 'src/utils';
+import * as userService from 'src/services/user.service';
 
 /**
- * Find all stocks.
+ * Find all the stocks available in the user's country.
  *
+ * @param userId The user id.
  * @returns The stocks found.
  */
-export const findAll = async (): Promise<IStockDocument[]> => {
-  const stocks = await Stock.find();
+export const findAll = async (userId: string): Promise<IStockDocument[]> => {
+  const user = await userService.findById(userId);
+
+  if (!user) {
+    throw new HttpError('El usuario no existe', StatusCodes.NOT_FOUND);
+  }
+
+  const countryId = user.country;
+
+  const stocks = await Broker.aggregate([
+    {
+      $match: {
+        countries: countryId,
+      },
+    },
+    {
+      $lookup: {
+        from: 'stocks',
+        localField: 'stocks',
+        foreignField: '_id',
+        as: 'stocks',
+      },
+    },
+    {
+      $unwind: '$stocks',
+    },
+    {
+      $replaceRoot: {
+        newRoot: '$stocks',
+      },
+    },
+  ]);
 
   return stocks;
 };
 
 /**
  * Find a stock by id.
  *
+ * @param userId The user id.
  * @param id The stock id.
  * @returns The stock found.
  */
 export const findById = async (
+  userId: string,
   id: string
 ): Promise<IStockDocument | null> => {
-  const stock = await Stock.findById(id);
+  const user = await userService.findById(userId);
 
-  if (!stock) {
-    throw new HttpError('La accion no existe', StatusCodes.NOT_FOUND);
+  if (!user) {
+    throw new HttpError('El usuario no existe', StatusCodes.NOT_FOUND);
   }
 
+  const countryId = user.country;
+
+  const stockResult = await Broker.aggregate<IStockDocument>([
+    {
+      $match: {
+        countries: countryId,
+      },
+    },
+    {
+      $lookup: {
+        from: 'stocks',
+        localField: 'stocks',
+        foreignField: '_id',
+        as: 'stocks',
+      },
+    },
+    {
+      $unwind: '$stocks',
+    },
+    {
+      $replaceRoot: {
+        newRoot: '$stocks',
+      },
+    },
+    {
+      $match: {
+        _id: id,
+      },
+    },
+  ]);
+
+  if (!stockResult.length) {
+    throw new HttpError('La accion no esta disponible', StatusCodes.NOT_FOUND);
+  }
+
+  const stock = stockResult[0];
+
   return stock;
 };
 

src/services/user.service.ts

@@ -24,7 +24,7 @@ import {
 export const findOne = async (
   filter: Record<string, unknown>
 ): Promise<IUserDocument | null> => {
-  const user = await User.findOne(filter).populate('country currency');
+  const user = await User.findOne(filter);
 
   return user;
 };