Allow users to be on both pull and push buckets (#37)

Fixes collision when user is on pull and push
moj-analytical-services · Jun 15, 2023 · 632e3ab · 632e3ab
1 parent 8ebf8ae
commit 632e3ab
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/__main__.py b/__main__.py
@@ -63,7 +63,7 @@
     )
     for user in users:
         RolePolicy(
-            resource_name=user,
+            resource_name=user + "_exports_pull",
             policy=role_policy.json,
             role=user,
             name=f"hub-exports-pull-{name}",

diff --git a/data_engineering_exports/push.py b/data_engineering_exports/push.py
@@ -236,7 +236,7 @@ def __init__(self, username: str, export_bucket: Bucket, prefixes: List[str]):
             )
         )
         self._role_policy = RolePolicy(
-            resource_name=username,
+            resource_name=username + "_exports_push",
             policy=self._policy_document.json,
             role=username,
             name="hub_exports",

diff --git a/pull_datasets/pull_permission_test.yaml b/pull_datasets/pull_permission_test.yaml
@@ -2,4 +2,4 @@ name: pull-permission-test
 pull_arns:
   - arn:aws:iam::684969100054:role/restricted-admin
 users:
-  - alpha_user_mralecjohnson
+  - alpha_user_jhpyke