Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs pages - page last changed time not correct #1909

Closed
ADBond opened this issue Jan 30, 2024 · 3 comments · Fixed by #1917
Closed

Docs pages - page last changed time not correct #1909

ADBond opened this issue Jan 30, 2024 · 3 comments · Fixed by #1917
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@ADBond
Copy link
Contributor

ADBond commented Jan 30, 2024

Revision info at bottom of pages is not specific to pages or revisions, but just gives the time of the last site build.

Relevant mkdocs build warning:
[git-revision-date-localized-plugin] Unable to find a git directory and/or git is not installed. Option 'fallback_to_build_date' set to 'true': Falling back to build date

Possibly as docs/ is not itself a git repo - this may have broken when we migrated splink_demos into this repo.

@ADBond ADBond added bug Something isn't working documentation Improvements or additions to documentation labels Jan 30, 2024
@ADBond
Copy link
Contributor Author

ADBond commented Jan 30, 2024

This also contributes quite a bit of noise to the docs build logs (though is not the only culprit)

@ADBond ADBond reopened this Feb 12, 2024
@ADBond
Copy link
Contributor Author

ADBond commented Feb 12, 2024

While the plugin is now functioning correctly, it is not running correctly in github actions, as currently not enough git history is available in the context in which it runs:

WARNING:root:
                [git-revision-date-localized-plugin] Running on GitHub Actions might lead to wrong
                Git revision dates due to a shallow git fetch depth.

                Try setting fetch-depth to 0 in your GitHub Action
                (see https://github.com/actions/checkout).
                

@ADBond
Copy link
Contributor Author

ADBond commented Jul 25, 2024

No longer using this plugin with Splink 4 docs

@ADBond ADBond closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant