Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim documentation dependencies #1917

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Trim documentation dependencies #1917

merged 1 commit into from
Feb 8, 2024

Conversation

ADBond
Copy link
Contributor

@ADBond ADBond commented Feb 1, 2024

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Fixes #1909.
Committer info now appears properly, and a bit less noise from the build.

Give a brief description for the solution you have provided

semiliterate was causing some weird paths issue which led to the above problem with git-revision-date-localized-plugin. I couldn't find anywhere we were using it, so removed it, along with some other packages from the requirements that we don't need.

Let me know if I'm mistaken and these are needed somewhere I've missed!

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

@ADBond ADBond added documentation Improvements or additions to documentation dev labels Feb 1, 2024
@ADBond ADBond requested a review from RossKen February 1, 2024 11:05
Copy link
Contributor

@RossKen RossKen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to get round to this!

Good stuff - the timings now seem to work on the docs 🎉

@ADBond ADBond merged commit 73f1338 into master Feb 8, 2024
2 checks passed
@ADBond ADBond deleted the tidy-docs-venv branch February 8, 2024 18:28
@ADBond
Copy link
Contributor Author

ADBond commented Feb 8, 2024

Hmmm, the build seems to have now failed the link-checker. I will try and fix this tomorrow - if anything pressing comes up docs-wise or if it proves more involved can revert this change

This was referenced Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs pages - page last changed time not correct
2 participants