Bug in save model to JSON

[aymonwuolanne]

What happens?

When running linker.save_model_to_json() the field tf_minimum_u_value is dropped from comparison levels. This is because the implementation of as_dict() for ComparisonLevel doesn't mention it.

To Reproduce

import splink.comparison_level as cl

c = cl.ComparisonLevel({"sql_condition": "name_l = name_r", "label_for_charts": "exact match", "tf_minimum_u_value": 1e-4})

print(c.as_dict())

OS:

Windows (WSL)

Splink version:

3.9.13

Have you tried this on the latest master branch?

• I agree

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

• I agree