Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added tf_minimum_u_value to as_dict method #2122

Merged
merged 2 commits into from
Apr 2, 2024
Merged

added tf_minimum_u_value to as_dict method #2122

merged 2 commits into from
Apr 2, 2024

Conversation

aymonwuolanne
Copy link
Contributor

@aymonwuolanne aymonwuolanne commented Apr 1, 2024 •
edited
Loading

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Fix for #2061

Give a brief description for the solution you have provided

Included tf_minimum_value in as_dict() for ComparisonLevel.

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

RobinL
RobinL approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@RobinL RobinL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@RobinL RobinL merged commit 065c4d8 into moj-analytical-services:master Apr 2, 2024
10 checks passed
@RobinL RobinL mentioned this pull request Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinL RobinL RobinL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aymonwuolanne @RobinL