Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table deletion functionality to spark delta tables #1526

Conversation

ardila1108
Copy link
Contributor

@ardila1108 ardila1108 commented Aug 15, 2023

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Give a brief description for the solution you have provided

Added table deletion feature to the spark API objects to handle table deletions when using Databricks. Tables get stored in Delta Lake and there is not an easy intuitive way to delete all the intermediate tables. This PR solves that issue

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

@ThomasHepworth
Copy link
Contributor

Thanks for this PR! Would you mind adding a quick description above so this PR is documented and I'll check and approve this.

Copy link
Contributor

@ThomasHepworth ThomasHepworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this works on our end and looks great!

It should go live later this week.

@ThomasHepworth ThomasHepworth merged commit b21321c into moj-analytical-services:master Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants