Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-zero estimate_u_values #162

Merged
merged 4 commits into from
Dec 24, 2020
Merged

Non-zero estimate_u_values #162

merged 4 commits into from
Dec 24, 2020

Conversation

samnlindsay
Copy link
Contributor

@samnlindsay samnlindsay commented Dec 24, 2020

Closes #161

Trivial fix to ensure estimate_u_probs returns at least 1/target_rows for all u values (equivalent to 1 comparison found for that gamma level)

Warning to users on manually setting any m_probabilities or u_probabilities to zero.

@RobinL
Copy link
Member

RobinL commented Dec 24, 2020

Nice. Can you:
(1) increment splink version in toml file
(2) expand the comment in the code to include a hyperlink to the issue: #161

@samnlindsay samnlindsay merged commit 19f36ed into master Dec 24, 2020
@samnlindsay samnlindsay deleted the sticky_probs branch December 24, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

m- and u-probabilities get "stuck" if set to zero
2 participants