Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix problem with csv overwriting in spark #1635

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

ThomasHepworth
Copy link
Contributor

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

#1455

Give a brief description for the solution you have provided

I've simply added the spark "overwrite" mode to the to_csv method. Alternatively, we could delete the folder if the user has selected they want to overwrite. However, I don't think it's worth the effort.

@ThomasHepworth ThomasHepworth linked an issue Oct 3, 2023 that may be closed by this pull request
Copy link
Contributor

@RossKen RossKen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this feels like the right solution instead of deleting folders 👍

@ThomasHepworth ThomasHepworth merged commit 66e133c into master Oct 5, 2023
8 checks passed
@ThomasHepworth ThomasHepworth deleted the fix_spark_csv_overwrite branch October 5, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SparkDataFrame to_csv / to_parquet not overwriting
2 participants