Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binder to point to splink repo #1655

Merged
merged 13 commits into from
Oct 18, 2023
Merged

Update binder to point to splink repo #1655

merged 13 commits into from
Oct 18, 2023

Conversation

RobinL
Copy link
Member

@RobinL RobinL commented Oct 17, 2023

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Now that all the demos have been migrated to the main Splink repo from splink_demos, we need to update the binder config

I have:

  • Decided not to install pyspark to keep the image size down
  • Explicitly specified the python runtime in runtime.txt
  • Installed pyarrow to ensure parquet datasets can be read in

The binder folder is a special folder that binder looks for to set up the env

Binder links:

Tutorial
Binder

Examples
Binder

You can't link to a .md in binder, only a .ipynb so strict speaking we should convert the examples index to ipynb and link there, but prob best to just get this going first

Once this is merged we can double check it works, and then i will archive splink_demos

I have validated that the release action works in a test repo here:
https://github.com/RobinL/test_binder_not_dir/actions/runs/6558104713/job/17810999709

There does seem to be a bit of an issue with it failing to start sporadically, maybe due to this

image

@RobinL RobinL mentioned this pull request Oct 17, 2023
4 tasks
@RobinL RobinL changed the title Binder branch Update binder to point to splink repo Oct 17, 2023
@RobinL RobinL requested a review from RossKen October 18, 2023 08:16
Copy link
Contributor

@RossKen RossKen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it all works from my end! 🎉

@RobinL
Copy link
Member Author

RobinL commented Oct 18, 2023

Thanks!

@RobinL RobinL merged commit 981b427 into master Oct 18, 2023
3 checks passed
@RobinL RobinL deleted the binder_branch branch October 18, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants