Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
Previously
test_helpers
depended on thespark
fixture. That means this gets created whenever we request thetest_helpers
fixture, which is slow (and particularly annoying if you're just running e.g.duckdb
tests).Give a brief description for the solution you have provided
Now both
test_helpers
andspark
fixtures use a helper function, with the upshot thatspark
is only created intest_helpers
whenever aSparkTestHelper
is instantiated (which should only happen when you are runningspark
tests, due toLazyDict
)Currently this means that
spark
is created afresh each time we access aSparkTestHelper
, which is not ideal.PR Checklist