Remove unused code and improve the Athena Linker #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinL
reviewed
Dec 1, 2023
tests/test_full_example_athena.py
Outdated
| @@ -1,23 +1,26 @@ | |||
| import os | |||
|
|
|||
| # Skip if no valid boto3 connection exists | |||
| # try: | |||
There was a problem hiding this comment.
this is what's causing the tests to fail
RobinL
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
Should resolve #1686
Give a brief description for the solution you have provided
This PR:
_names_of_tables_created_by_splink.drop_tables_in_current_splink_run. Now, it will look at tables in the cache and clean these.Comments:
drop_tables_in_current_splink_runfor other linkers. This would then simplify the clean-up process for all users, across all linkers.PR Checklist