Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model evaluation guide #1916

Merged
merged 9 commits into from
Feb 2, 2024
Merged

Model evaluation guide #1916

merged 9 commits into from
Feb 2, 2024

Conversation

RossKen
Copy link
Contributor

@RossKen RossKen commented Jan 31, 2024

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Give a brief description for the solution you have provided

Basic outline of model evaluation (most of the content is linked off to elsewhere) so is just a high level guide

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

zslade
zslade approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@zslade zslade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! Just a few suggestions from me

RossKen and others added 7 commits February 2, 2024 16:01
@RossKen @zslade
Update docs/topic_guides/evaluation/model.md
e9ad95d 
Co-authored-by: Zoe Slade <zoe.slade@gmail.com>
@RossKen @zslade
Update docs/topic_guides/evaluation/model.md
df7cf6f 
Co-authored-by: Zoe Slade <zoe.slade@gmail.com>
@RossKen @zslade
Update docs/topic_guides/evaluation/model.md
6a1bae9 
Co-authored-by: Zoe Slade <zoe.slade@gmail.com>
@RossKen @zslade
Update docs/topic_guides/evaluation/model.md
5773786 
Co-authored-by: Zoe Slade <zoe.slade@gmail.com>
@RossKen @zslade
Update docs/topic_guides/evaluation/model.md
893725e 
Co-authored-by: Zoe Slade <zoe.slade@gmail.com>
@RossKen @zslade
Update docs/topic_guides/evaluation/model.md
b4874ae 
Co-authored-by: Zoe Slade <zoe.slade@gmail.com>
@RossKen @zslade
Update docs/topic_guides/evaluation/model.md
03b597a 
Co-authored-by: Zoe Slade <zoe.slade@gmail.com>
@RossKen RossKen merged commit 3fa517f into master Feb 2, 2024
5 checks passed
@RossKen RossKen deleted the model-evaluation-guide branch February 2, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zslade zslade zslade approved these changes

@ThomasHepworth ThomasHepworth Awaiting requested review from ThomasHepworth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RossKen @zslade