Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use .sql not .execute #1952

Merged
merged 1 commit into from
Feb 15, 2024
Merged

use .sql not .execute #1952

merged 1 commit into from
Feb 15, 2024

Conversation

RobinL
Copy link
Member

@RobinL RobinL commented Feb 9, 2024

Improves runtimes - see #1950 for description and benchmarking

Closes #1950

Copy link
Contributor

@ADBond ADBond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Will need to do the same for Splink 4 at some point

@RobinL RobinL merged commit 154dfdd into master Feb 15, 2024
10 checks passed
@RobinL RobinL deleted the use_sql_not_execute branch February 15, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Performance improvement from using .sql() rather than .execute() in duckdb?
2 participants