Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update u probability formula and example in fellegi_sunter.md #2036

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

jacuna88
Copy link
Contributor

@jacuna88 jacuna88 commented Mar 7, 2024

u explanation should match formula and example

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

No

Give a brief description for the solution you have provided

The formula and example of u probability is almost copy-pasted from the m probability,
the editor forgot to use u in te formula and the not condition on the record for the example

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

u explanation should match formula and example
@jacuna88 jacuna88 changed the title Update fellegi_sunter.md Update u probability formula and example in fellegi_sunter.md Mar 7, 2024
Copy link
Member

@RobinL RobinL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@RobinL RobinL merged commit 9b790a5 into moj-analytical-services:master Mar 7, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants