Further br fixes #2106
Merged
Further br fixes #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinL
commented
Mar 27, 2024
| if len(cols_as_string) == 0: | ||
| return block_on("1") | ||
| br: BlockingRuleCreator = CustomRule("1=1", linker._sql_dialect) |
There was a problem hiding this comment.
This type hint was needed for mypy, without it you got an splink/find_brs_with_comparison_counts_below_threshold.py:75: error: Incompatible types in assignment (expression has type "BlockingRuleCreator", variable has type "CustomRule") [assignment] error
RobinL
commented
Mar 27, 2024
| @@ -258,3 +258,19 @@ def count_comparisons_from_blocking_rule_pre_filter_conditions_sqls( | |||
| sqls.append({"sql": sql, "output_table_name": "__splink__total_of_block_counts"}) | |||
|
|
|||
| return sqls | |||
|
|
|||
|
|
|||
| def count_comparisons_from_blocking_rule_pre_filter_conditions( | |||
There was a problem hiding this comment.
Moved out of linker to reduce line count and so it can be more easily called from elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes apply to the 'beta' (private) auto-blocking functions which I added