added-doc-about-architecture #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sukriti-sood <soodsukriti1111@gmail.com>
Signed-off-by: Sukriti-sood <soodsukriti1111@gmail.com>
Signed-off-by: Sukriti-sood <soodsukriti1111@gmail.com>
Sukriti-sood
force-pushed
the
architecture-doc
branch
from
e6d6c32
to
9552d14
Compare
HarshCasper
requested review from
HarshCasper,
aornugent,
shloka-gupta and
shubhamkarande13
HarshCasper
requested changes
Sep 26, 2021
There was a problem hiding this comment.
This actually looks quite good! Thanks for the great work.
Few comments on the same:
-
The docs are not being references anywhere so they are not actually being rendered. You can validate this here: https://moja-global-documentation--101.org.readthedocs.build/en/101/index.html
-
The location for these docs seems to be wrong. They should not be a part of the
DeveloperWorkflowas far as I believe. -
I see some doc pieces like
synchronized_events.rstandtemporal_distribution.rstleft incomplete. Is that intentional?
Signed-off-by: Sukriti-sood <soodsukriti1111@gmail.com>
Sukriti-sood
force-pushed
the
architecture-doc
branch
from
2834153
to
7ae2104
Compare
|
aornugent
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Documentation on FLINT Architecture( In progress)
Fixes #76
Type of change