chore: pull in redis/pub-sub/kvs/ttk/state plugin/state machine code for upcoming flows #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewisdaly
requested changes
Jul 8, 2021
docker-compose.yml
Outdated
| @@ -18,6 +18,9 @@ services: | |||
| - mojaloop-net | |||
| depends_on: | |||
| - mysql | |||
| - redis | |||
| extra_hosts: | |||
There was a problem hiding this comment.
Why do we need extra_hosts?
There was a problem hiding this comment.
Don't believe we need it. Just mindless copying.
Let me know if I set up the compose files properly like the pisp repo.
There was a problem hiding this comment.
Cool. Yeah it looks fine to me apart from that section. We'll know if the config is wrong because the tests will break.
lewisdaly
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.