Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add /thirpartyRequests/verifications resource support #83

Merged

Conversation

lewisdaly
Copy link
Contributor

  • First pass at supporting /thirdpartyRequests/verifications
  • Initial state machine setup for verifyTransaction... perhaps overkill, but seems like a good way to do async things
  • Minor refactor to move state machines out of /src/model, and into /src/domain/stateMachine. Model is for database things (but I can understand the mix up)

We will need to come back to this code to implement the actual verification of an attestation, and we can take care of some other cleanup then:

  • sdk-standard-components support for a proper method called putThirdpartyVerification
  • auth-service changes to the payload of POST /thirdpartyRequests/verifications

@lewisdaly lewisdaly merged commit d6e2137 into mojaloop:master Aug 9, 2021
@lewisdaly lewisdaly deleted the feat/2372-verifications-resource branch August 12, 2021 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants