Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Notification failure - NDC threshold breach, Position reset - ML DEV v5.5.1 #720

Closed
4 tasks done
sri-miriyala opened this issue Apr 4, 2019 · 3 comments
Closed
4 tasks done
Assignees
Milestone

Comments

@sri-miriyala
Copy link

sri-miriyala commented Apr 4, 2019

Description:

  1. Email notification is not being sent to payerfsp even though its position breached it's threshold limit.
  2. Position reset email notification has not been sent to payeefsp even though its position updated during Settlements - PS_TRANSFERS_RESERVED state. this is happenning with only few fsps.

Expected Behavior:

  1. Email notification has to be sent to both HUB operator and payerfsp when payerfsp breaches its threshold limit %
  2. Position reset email notification has to be sent to both HUB operator and payeefsp after the settlements - Reserved state. Payerfsp has to receive this email after settlements - committed state.

Actual behavior:

  1. No notifications emails received at the provided email address in contacts regarding threshold breach
  2. Few notification emails received at the provided email address in contacts reg position resets but not for all FSPs.

Tasks

  • simulate the issue for settlements
  • change switchMap to flatMap and investigate behavior
  • research about Observables error handling
  • solve Complete-on-Error Observables behavior

Specifications

  • Component (if known): central services
  • Version: v5.5.1
  • Platform: AWS DEV0
  • Subsystem: email-notifier, CEP
  • Type of testing: Functional
  • Bug found/raised by: @sri-miriyala

Notes:

  • Severity when opened:
  • Priority when opened:
@elnyry-sam-k elnyry-sam-k changed the title Email Notification failure - NDC threshold breach, Position reset - ML DEV v5.4.2 Email Notification failure - NDC threshold breach, Position reset - ML DEV v5.5.1 Apr 4, 2019
@elnyry-sam-k elnyry-sam-k assigned vgenev and unassigned bothadeon Apr 4, 2019
@elnyry-sam-k elnyry-sam-k added this to the Sprint 5.5 milestone Apr 4, 2019
@sri-miriyala
Copy link
Author

NDC threshold beach email is working fine now... only issue with position reset email notifications.

No specific behavior for this position reset email notifications. Few fsps receiving emails while few fsps are not receiving these emails. Worked with Valentine on this. He is following up on the email server service.
Changed the title of the bug so that reflects only the current issue

@vgenev
Copy link

vgenev commented Apr 10, 2019

The NDC Breach might have been performing like that, because of the same issue as the settlements or because of an issue we found yesterday that stops the NDC threshold flow if there is an error. Currently I am working on error handling with Observables, since its little bit different than normal error handling, unfortunately.

@elnyry-sam-k
Copy link
Member

Sri confirmed that this is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants