resolves asciidoctor#1460 don't crash if colspan exceeds colspec

mojavelinux · Oct 10, 2015 · 8457a04 · 8457a04
1 parent 8a00d8b
commit 8457a04
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/asciidoctor/table.rb b/lib/asciidoctor/table.rb
@@ -473,7 +473,7 @@ def close_cell(eol = false)
         end
       else
         # QUESTION is this right for cells that span columns?
-        column = @table.columns[@current_row.size]
+        return unless (column = @table.columns[@current_row.size])
       end
 
       cell = Table::Cell.new(column, cell_text, cell_spec, @last_cursor)

diff --git a/test/tables_test.rb b/test/tables_test.rb
@@ -579,6 +579,22 @@
       assert_xpath '/table/tbody/tr[3]/td[3]/p[text()="c"]', output, 1
     end
 
+    test 'ignores cell with colspan that exceeds colspec' do
+      input = <<-EOS
+[cols="1,1"]
+|===
+3+|A
+|B
+a|C
+
+more C
+|===
+      EOS
+      output = render_embedded_string input
+      assert_css 'table', output, 1
+      assert_css 'table *', output, 0
+    end
+
     test 'paragraph, verse and literal content' do
       input = <<-EOS
 [cols=",^v,^l",options="header"]