Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev setup takes a long time #23

Closed
sa- opened this issue Jun 16, 2024 · 5 comments · Fixed by #25
Closed

Dev setup takes a long time #23

sa- opened this issue Jun 16, 2024 · 5 comments · Fixed by #25

Comments

@sa-
Copy link
Collaborator

sa- commented Jun 16, 2024

source: #21 (comment)

Making pyenv an optional but recommended dependency should suffice.
Switching from poetry to uv will allow people install venv's using pip

@martinvuyk
Copy link
Contributor

martinvuyk commented Jun 16, 2024

Hi, thanks a lot for the changes. Deleted and tried again and it works with python 3.10 with no hiccups.
just did (less than 2 minutes):

  • virtualenv venv
  • source ./venv/bin/activate
  • pip install -r requirements.txt
  • pip install uv
  • make setup
    though make setup gives me an error
make: ./.venv/bin/pre-commit: No such file or directory
make: *** [Makefile:24: setup] Error 127

Other than that the tests run fine

@sa-
Copy link
Collaborator Author

sa- commented Jun 16, 2024

Ah uv is not a python package it's a rust tool. I think you could install it via pip but I'm not sure why one would. You can see the installation instructions

If you are creating your own venv and installing via pip then you actually don't need UV.

Alright it fails makefile assumes the folder is called .venv and not venv. I can add a note for this

Also virtualenv is deprecated. venv comes with Python already. If the venv is recreated on your machine with python3 -m venv .venv everything should work

@sa-
Copy link
Collaborator Author

sa- commented Jun 16, 2024

I'm closing this issue for now, but if make setup doesn't work after recreating the venv following the above instructions then feel free to reopen the issue. The README is also updated to include this detail

@martinvuyk
Copy link
Contributor

assumes the folder is called .venv and not venv

uv is creating a .venv folder though, but now that I see it it says python 3.11 and I'm running on 3.10 globally, so maybe it's because of that. Anyway, testing works which is the most important thing :)

@petacube
Copy link

petacube commented Jun 16, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants