New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No heroku-16 build #13

Open
csuhta opened this Issue Dec 1, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@csuhta

csuhta commented Dec 1, 2017

I have:

$  heroku buildpacks
1. https://github.com/heroku/heroku-buildpack-apt
2. https://github.com/mojodna/heroku-buildpack-jemalloc.git#v3.6.0
3. heroku/ruby

When I deploy, the build phase crashes:

[...]
remote: -----> jemalloc app detected
remote: -----> Vendoring binaries
remote:        Fetching https://s3.amazonaws.com/mojodna-heroku/heroku-16/jemalloc-3.6.0-1.tar.gz
remote: 
remote: gzip: stdin: not in gzip format
remote: tar: Child returned status 1
remote: tar: Error is not recoverable: exiting now
remote:  !     Push rejected, failed to compile jemalloc app.
remote: 
remote:  !     Push failed
[...]

This file doesn't exist: https://s3.amazonaws.com/mojodna-heroku/heroku-16/jemalloc-3.6.0-1.tar.gz

Everything is fine if I don't pin to v3.6.0.

Is there a reason 3.6.0 is still shown as a fallback option? Is it still supported?

@nateberkopec

This comment has been minimized.

Show comment
Hide comment
@nateberkopec

nateberkopec Dec 4, 2017

Collaborator

We need to create a heroku-16 build, we haven't done that yet.

Collaborator

nateberkopec commented Dec 4, 2017

We need to create a heroku-16 build, we haven't done that yet.

@nateberkopec nateberkopec changed the title from Buildpack can't fetch jemalloc-3.6.0-1.tar.gz to No heroku-16 build Dec 4, 2017

@nateberkopec nateberkopec added the bug label Dec 4, 2017

gaffneyc added a commit to gaffneyc/heroku-buildpack-jemalloc that referenced this issue Dec 5, 2017

Rewrite build system for new versions and Heroku stacks
This allows new versions to be built for uploading by running
`make VERSION=5.0.1` rather than updating the hard coded version in
multiple places. I've also added support for building against either the
legacy cedar-14 architecture or heroku-16. While versions built on
cedar-14 appear to run on heroku-16, the newer stack should also mean a
newer and better tool chain.

I've removed the Dockerfile and switched to using Heroku's docker images
directly as this removes the need for cleaning them up afterwards. It
possibly makes debugging harder but having build.sh available should
avoid some of that.

Fixes mojodna#7
Fixes mojodna#13

gaffneyc added a commit to gaffneyc/heroku-buildpack-jemalloc that referenced this issue Dec 5, 2017

Rewrite build system for new versions and Heroku stacks
This allows new versions to be built for uploading by running
`make VERSION=5.0.1` rather than updating the hard coded version in
multiple places. I've also added support for building against either the
legacy cedar-14 architecture or heroku-16. While versions built on
cedar-14 appear to run on heroku-16, the newer stack should also mean a
newer and better tool chain.

I've removed the Dockerfile and switched to using Heroku's docker images
directly as this removes the need for cleaning them up afterwards. It
possibly makes debugging harder but having build.sh available should
avoid some of that.

Fixes #2
Fixes mojodna#7
Fixes mojodna#13

gaffneyc added a commit to gaffneyc/heroku-buildpack-jemalloc that referenced this issue Dec 5, 2017

Rewrite build system for new versions and Heroku stacks
This allows new versions to be built for uploading by running
`make VERSION=5.0.1` rather than updating the hard coded version in
multiple places. I've also added support for building against either the
legacy cedar-14 architecture or heroku-16. While versions built on
cedar-14 appear to run on heroku-16, the newer stack should also mean a
newer and better tool chain.

I've removed the Dockerfile and switched to using Heroku's docker images
directly as this removes the need for cleaning them up afterwards. It
possibly makes debugging harder but having build.sh available should
avoid some of that.

Fixes #2
Fixes mojodna#7
Fixes mojodna#13
@EGimenoS

This comment has been minimized.

Show comment
Hide comment
@EGimenoS

EGimenoS May 4, 2018

I have the same exact problem. I read that jemalloc 3.6 works better with Ruby, I'm using Ruby 2.3.1.

EGimenoS commented May 4, 2018

I have the same exact problem. I read that jemalloc 3.6 works better with Ruby, I'm using Ruby 2.3.1.

@timobleeker

This comment has been minimized.

Show comment
Hide comment
@timobleeker

timobleeker Jun 19, 2018

I encountered this issue today. Are there any plans for building 3.6 for heroku 16?
Or should I just be using the latest version instead? I have heard of instabilities with 4.0, and unknown performance with 5.0

timobleeker commented Jun 19, 2018

I encountered this issue today. Are there any plans for building 3.6 for heroku 16?
Or should I just be using the latest version instead? I have heard of instabilities with 4.0, and unknown performance with 5.0

@nateberkopec

This comment has been minimized.

Show comment
Hide comment
@nateberkopec

nateberkopec Jun 21, 2018

Collaborator

See #18.

Collaborator

nateberkopec commented Jun 21, 2018

See #18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment