Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NestMember requires ASM7 #134

Closed
bradcupit opened this issue Dec 21, 2020 · 0 comments · Fixed by #135
Closed

NestMember requires ASM7 #134

bradcupit opened this issue Dec 21, 2020 · 0 comments · Fixed by #135

Comments

@bradcupit
Copy link
Contributor

This PR #91 fixed JDK 9+ compatibility but looks like there's one more place to replace ASM5 with ASM7.

NestMember requires ASM7

I saw the above error when building a work project using animal-sniffer. That work project uses JDK 11 but compiles some modules for JDK 8 and uses animal-sniffer to verify correct JDK 8 api usage. I grepped the animal-sniffer code and found this one remaining occurrence of ASM5. After Replacing it with ASM7, and doing a local mvn clean install on animal-sniffer, my work project built correctly.
@bradcupit bradcupit mentioned this issue Dec 21, 2020
Merged
olamy pushed a commit that referenced this issue Dec 23, 2020
@bradcupit
Fix "NestMember requires ASM7" (#135)
3976979 
Fixes #134

I saw the above error when building a work project that uses animal-sniffer. That work project uses JDK 11 but compiles some modules for JDK 8 and uses animal-sniffer to verify correct JDK 8 api usage. I grepped the animal-sniffer code and found one remaining occurrence of ASM5. After Replacing it with ASM7, and doing a local `mvn clean install` on animal-sniffer, my work project built correctly.

Related to this PR: #91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "NestMember requires ASM7"
1 participant
@bradcupit