Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade asm 6.2 #50

Merged
merged 13 commits into from Jun 20, 2018
Merged

upgrade asm 6.2 #50

merged 13 commits into from Jun 20, 2018

Conversation

olamy
Copy link
Member

@olamy olamy commented Jun 19, 2018

Signed-off-by: olivier lamy olamy@apache.org

Signed-off-by: olivier lamy <olamy@apache.org>
Signed-off-by: olivier lamy <olamy@apache.org>
Signed-off-by: olivier lamy <olamy@apache.org>
Signed-off-by: olivier lamy <olamy@apache.org>
Copy link

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good though I am not familiar with this codebase

@olamy olamy mentioned this pull request Jun 19, 2018
Signed-off-by: olivier lamy <olamy@apache.org>
Signed-off-by: olivier lamy <olamy@apache.org>
Signed-off-by: olivier lamy <olamy@apache.org>
Signed-off-by: olivier lamy <olamy@apache.org>
Signed-off-by: olivier lamy <olamy@apache.org>
@olamy
Copy link
Member Author

olamy commented Jun 19, 2018

FYI not trivial... javaBootClasspathDetector not working with jdk10.

Signed-off-by: olivier lamy <olamy@apache.org>
Signed-off-by: olivier lamy <olamy@apache.org>
Signed-off-by: olivier lamy <olamy@apache.org>
Signed-off-by: olivier lamy <olamy@apache.org>
@olamy olamy merged commit db126de into mojohaus:master Jun 20, 2018
@olamy olamy deleted the asm_upgrade_6_2 branch June 20, 2018 02:30
@olamy olamy added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants