Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildnumber plugin does not fail on doCheck if format is specified #5

Closed
rlaun opened this issue Jul 15, 2015 · 2 comments
Closed

Buildnumber plugin does not fail on doCheck if format is specified #5

rlaun opened this issue Jul 15, 2015 · 2 comments
Labels

Comments

@rlaun
Copy link

rlaun commented Jul 15, 2015

In the create mojo, the doCheck option is not honored if format is configured.
This can be verified by adding this to the plugin configuration in the integration test MBUILDNUM-85:

  <format>{0,date,yyyyMMdd}-{1}</format>
  <items>
    <item>timestamp</item>
    <item>scmVersion</item>
  </items>
@rlaun
Copy link
Author

rlaun commented Jul 15, 2015

The proposed fix seems too trivial... not sure why the check was only in the else branch.

@khmarbaise khmarbaise added this to the Release 1.4 milestone Jul 16, 2015
arcasys pushed a commit to arcasys/buildnumber-maven-plugin that referenced this issue Sep 6, 2015
… specified (fixes Issue mojohaus#5 for mojohaus/buildnumber-maven-plugin: mojohaus#5
@arcasys
Copy link

arcasys commented Sep 6, 2015

This issue has been resolved in
https://github.com/arcasys/buildnumber-maven-plugin
Also, doCheck, and getRevisionsOnlyOnce will work with format.
Feel free to merge this change and let me know when you've done so, so I can delete my fork.

Thanks, Hans

@mfriedenhagen mfriedenhagen removed this from the Release 1.4 milestone Oct 6, 2015
@github-actions github-actions bot added the Stale label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants