Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore automatically module-info.class when maxJdkVersion < 1.9 #76

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

Vlatombe
Copy link
Contributor

Context: #46, #36, #75

Fix from #36 would cause unnecessary noise such as

[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53

This supercedes #75.

This fix takes a different approach: when maxJdkVersion < 1.9, module-info is just ignored automatically.

Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batmat batmat self-assigned this Mar 20, 2019
@batmat batmat requested a review from khmarbaise March 20, 2019 13:25
@batmat batmat merged commit d5bcf7e into mojohaus:master Mar 29, 2019
@batmat
Copy link
Member

batmat commented Apr 2, 2019

released as 1.2 in staging, vote in progress since a few minutes ago.

Will publish to Central in 72 hours w/o pushback.

@batmat
Copy link
Member

batmat commented Apr 2, 2019

@Vlatombe
Copy link
Contributor Author

Vlatombe commented Apr 2, 2019

Cool, thanks @batmat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants