Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-overwrite\pom.xml IT fails in some environments #140

Closed
lasselindqvist opened this issue Mar 30, 2020 · 3 comments · Fixed by #154
Closed

no-overwrite\pom.xml IT fails in some environments #140

lasselindqvist opened this issue Mar 30, 2020 · 3 comments · Fixed by #154
Milestone
release:1.2.3

Comments

@lasselindqvist
Copy link
Collaborator

Task: Release from master
Note: Lost my private keys due to data loss, so had to create a new one so the signing keys for the release will differ from the previous.
@lasselindqvist
Copy link
Collaborator Author

lasselindqvist commented Mar 30, 2020 •
edited 

    [INFO] Building: no-overwrite\pom.xml
    [INFO] run post-build script verify.groovy
    [INFO]   The post-build script did not succeed. assert now - flattendPom.lastModified() > 20*1000
           |   | |           |              |   |
           |   59|           1585580833725  |   20000
           |     |                          false
           |     C:\Users\lasse\git\upstream\flatten-maven-plugin\target\it\no-overwrite\.flattened-pom.xml
           1585580833784
    [INFO]           no-overwrite\pom.xml ............................. FAILED (4.2 s)

still fails for me.

Environment:

C:\Users\lasse\git\upstream\flatten-maven-plugin>mvn --version
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\ProgramData\chocolatey\lib\maven\apache-maven-3.6.3\bin\..
Java version: 11.0.6, vendor: AdoptOpenJDK, runtime: C:\Program Files\AdoptOpenJDK\jdk-11.0.6.10-hotspot
Default locale: fi_FI, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

@lasselindqvist lasselindqvist changed the title Release from master no-overwrite\pom.xml IT fails in some environments Apr 2, 2020
@lasselindqvist
Copy link
Collaborator Author

lasselindqvist commented Apr 2, 2020 •
edited

Modified the task to be about fixing the IT, since the release has been done regardless. This anyway needs some attention at some point.

@stephaniewang526 stephaniewang526 mentioned this issue May 12, 2020
Closed
@stephaniewang526
Copy link
Contributor

this is related to #136

yangnuoyu pushed a commit to yangnuoyu/flatten-maven-plugin that referenced this issue May 26, 2020
fix mojohaus#140 by separating no-overwritten test into two basing on…
65e17ac 
… maven version
@yangnuoyu yangnuoyu mentioned this issue May 26, 2020
Merged
@olamy olamy closed this as completed in #154 Jun 2, 2020
olamy pushed a commit that referenced this issue Jun 2, 2020
@yangnuoyu
Fix #140 by separating no-overwritten test into two basing on maven v…
6b5779f 
…ersion (#154)

* fix #140 by separating no-overwritten test into two basing on maven version

* parse maven version by ./mvnw -v

* remove redundent code

Co-authored-by: yangnuoyu <yangnuoyu@penguin>
@olamy olamy added this to the release:1.2.3 milestone Jun 12, 2020
hboutemy added a commit that referenced this issue Feb 28, 2021
@hboutemy
fixed Maven version detection using invoker.maven.version property
4a38133 
fixes issue introduced in #154 trying to fix #140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release:1.2.3
3 participants
@olamy @stephaniewang526 @lasselindqvist