Support licensesMerge user property #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will have some works on this project next week. --Enjoy and ShareTony Chemit
On nov. 16 2017, at 11:44 am, Baptiste Mathus <notifications@github.com> wrote:
@batmat requested your review on: mojohaus/license-maven-plugin#113 Support licensesMerge user property.
—You are receiving this because your review was requested.Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Hi there, Any updates? Thanks |
|
@tchemit , is there anything I can do to help to review this PR? |
|
Travis build fails... |
|
You are right, unfortunately that particular issue is not about this PR but something within the JAVA_HOME, see: #109 Cheers |
|
I will have a look at this one soon (sorry for this long silent period)... |
v1v
force-pushed
the
feature/licenseMergeUserProperty
branch
from
1e77f0d
to
699d12d
Compare
|
Thanks @tchemit , unfortunately there are broken ITs which looks like there is a broken URL when fetching the URL: |
v1v
force-pushed
the
feature/licenseMergeUserProperty
branch
2 times, most recently
from
b0648d2
to
d541aab
Compare
… when running licensesMerge
v1v
force-pushed
the
feature/licenseMergeUserProperty
branch
from
d541aab
to
6ecf906
Compare
|
Hi there, Any updates? Thanks |
|
bump |
|
At last... Thanks for the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to be able to define licenseMerges as User property by command line to avoid touching the pom.xml file.
One optional properties was added to the 'license:add-third-party' and therefore 'license:aggregate-add-third-party'
licenseMergesFile
Load file supplying information for merging licenses in final file. If defined then it gets precedence to the licenseMerges property.
User property is_: license.licenseMergesFile.
What do you think? Is this something others might get benefits?
Thanks