Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration property 'trimHeaderLine' doesn't take any effect. #128

Closed
xeagle2 opened this issue Apr 14, 2018 · 3 comments
Closed

Configuration property 'trimHeaderLine' doesn't take any effect. #128

xeagle2 opened this issue Apr 14, 2018 · 3 comments
Milestone
1.17

Comments

@xeagle2
Copy link
Contributor

xeagle2 commented Apr 14, 2018

Hi there,

Used version of the license-maven-plugin is 1.16.

When the 'trimHeaderLine' is set, it doesn't take any effect because every xxxTransformer implementation inherits AbstractFileHeaderTransformer where

public void setTrimHeaderLine( boolean trimLine )
{
    this.emptyLineAfterHeader = trimLine;
}

is assigned to this.emptyLineAfterHeader instead of this.trimHeaderLine.

It looks like an issue which would be useful to be resolved.

Thank you,
xeagle2 added a commit to xeagle2/license-maven-plugin that referenced this issue Apr 14, 2018
@xeagle2
Fixed "Configuration property 'trimHeaderLine' doesn't take any effect.
aefd67b 
mojohaus#128"
@xeagle2 xeagle2 mentioned this issue Apr 14, 2018
Merged
tchemit pushed a commit that referenced this issue Apr 14, 2018
@xeagle2 @tchemit
Fixed "Configuration property 'trimHeaderLine' doesn't take any effect.
0d1586f 
#128" (#130)
tchemit pushed a commit that referenced this issue Apr 14, 2018
@xeagle2 @tchemit
Fixed ''remove-file-header' goal leaves the '\n' character, which sho…
f8699f5 
…uld be avoided. #129' (#131)

* Fixed "Configuration property 'trimHeaderLine' doesn't take any effect. #128"

* Fixed "'remove-file-header' goal leaves the '\n' character, which should be avoided. #129"
@cjohnstoniv
Copy link

Has this been resolved? If so, can this be patched into a 1.16.1 release anytime soon?

@ppalaga
Copy link
Contributor

ppalaga commented Jan 4, 2019

The fix seems to have been merged. Feel free to reopen if that's not the case.

@xeagle2
Copy link
Contributor Author

xeagle2 commented Jan 6, 2019

Seems merged :)

@ppalaga ppalaga closed this as completed Jan 7, 2019
@ppalaga ppalaga added this to the 1.17 milestone Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.17
Development

No branches or pull requests
3 participants
@xeagle2 @cjohnstoniv @ppalaga