Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow redirects more than once #233

Closed
ppalaga opened this issue Feb 5, 2019 · 1 comment
Closed

Follow redirects more than once #233

ppalaga opened this issue Feb 5, 2019 · 1 comment
Assignees
Milestone

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Feb 5, 2019

We currently assume only one redirect can come as a response to the original license URL. In fact, the response to the redirect URL can be a redirect again, as happens with http://glassfish.java.net/public/CDDL+GPL_1_1.html:

$ curl -v http://glassfish.java.net/public/CDDL+GPL_1_1.html > /dev/null
< HTTP/1.0 302 Found
< Location: https://glassfish.java.net/public/CDDL+GPL_1_1.html
curl -v https://glassfish.java.net/public/CDDL+GPL_1_1.html > /dev/null
< HTTP/1.0 301 Moved Permanently
< Location: http://javaee.github.io/glassfish

Funny enough, https://javaee.github.io/glassfish/ does not contain the license.

@ppalaga
Copy link
Contributor Author

ppalaga commented Feb 5, 2019

http://www.opensource.org/licenses/LGPL-2.1 is a better example: it redirects to http://opensource.org/licenses/LGPL-2.1 and then to https://opensource.org/licenses/LGPL-2.1 where the actual license resides

ppalaga added a commit to ppalaga/mojohaus-license-maven-plugin that referenced this issue Feb 5, 2019
@ppalaga ppalaga closed this as completed in e2860a9 Feb 5, 2019
ppalaga added a commit that referenced this issue Feb 5, 2019
Fix #233 Follow redirects more than once
ppalaga added a commit to ppalaga/mojohaus-license-maven-plugin that referenced this issue Feb 8, 2019
ppalaga added a commit that referenced this issue Feb 8, 2019
Fix #242 Proxy settings ignored after #233
@ppalaga ppalaga added this to the 1.18 milestone Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant