Add the ability to transform a license url with a regular expression/replacement pair. #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebase done. |
ppalaga
requested changes
Jan 4, 2019
|
Rebase done and check style problems resolved. |
ppalaga
requested changes
Jan 4, 2019
src/main/java/org/codehaus/mojo/license/LicenseUrlReplacement.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/license/LicenseUrlReplacement.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/license/LicenseUrlReplacement.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/license/AbstractDownloadLicensesMojo.java
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/license/AbstractDownloadLicensesMojo.java
Outdated
Show resolved
Hide resolved
|
@k-wall any chance that you find time to address the review comments above? I'd like to merge and release the plugin. |
|
That was my rebase before starting work. I am currently addressing the
review comments. I should have a patch up with changes shortly.
…On Wed, 9 Jan 2019 at 10:14, Peter Palaga ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@k-wall <https://github.com/k-wall> I see a new commit but I do not see
any of the review comments resolved.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#167 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ARlgOh6DqinwQXba2uZiF97yx7J-Cbseks5vBcD5gaJpZM4Zgk13>
.
|
|
Thanks for the comments, I believe all are now resolved. |
ppalaga
requested changes
Jan 10, 2019
src/main/java/org/codehaus/mojo/license/AbstractDownloadLicensesMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/license/AbstractDownloadLicensesMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/license/AbstractDownloadLicensesMojo.java
Outdated
Show resolved
Hide resolved
|
@k-wall one more detail: Please squash all your commits into one, and use the follwing commit message: |
…gular expression/replacement pair
|
@ppalaga I've addressed your comments, reworded the commit message to refer to the #196, and rebased/squashed. I also attach a diff showing the code changes made to address your latest review to help you review efficiently. 0001-Changes-in-response-to-ppalaga-review-2019-01-10.patch.zip |
|
@k-wall thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a project to, say, workaround a project's duff or stale license metadata.
Fixes #154