Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #73 Class not found on mvn license:aggregate-third-party-report #220

Merged
merged 1 commit into from Feb 1, 2019

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Feb 1, 2019

Cherry-picked and reworded from
#215 by @digulla

@ppalaga ppalaga merged commit 0e66e96 into mojohaus:master Feb 1, 2019
This was referenced Feb 1, 2019
@Tibor17
Copy link
Contributor

Tibor17 commented Feb 1, 2019

@ppalaga
Why you did not use latest version 1.8?

@ppalaga
Copy link
Contributor Author

ppalaga commented Feb 1, 2019

@ppalaga
Why you did not use latest version 1.8?

I just adapted @digulla 's fix. There are reports in #73 that 1.8 brings other problems.

@Tibor17
Copy link
Contributor

Tibor17 commented Feb 1, 2019

@ppalaga
You mean this

With doxia 1.8 and 1.8.1, org/apache/maven/doxia/sink/SinkEventAttributeSet is missing (probably was moved to a new package org.apache.maven.doxia.sink.impl in 1.8).

I had to change the import section as well in Surefire but it works fine.

@ppalaga
Copy link
Contributor Author

ppalaga commented Feb 1, 2019

Feel free to send a PR.

@Tibor17
Copy link
Contributor

Tibor17 commented Feb 2, 2019

@ppalaga
Is there Jenkins build?
One unit test failed FreeMarkerHelperTest.testRenderTemplateForUpdateFileHeader().

@ppalaga
Copy link
Contributor Author

ppalaga commented Feb 2, 2019

Is there Jenkins build?

No, just TravisCI and AppVeyor. Jobs will start if you send a pull request.

@Tibor17
Copy link
Contributor

Tibor17 commented Feb 2, 2019

I applied Doxia 1.8 and fixed the import but I do not know what it has to do with newly failed IT ISSUE-80 where <file> is missing in licenses.xml, see log.txt :

[WARNING] Unable to retrieve license for dependency: org.jboss.xnio:xnio-api
[WARNING] http://repository.jboss.org/licenses/cc0-1.0.txt
[WARNING] connect timed out

Second IT which has failed with Doxia 1.8 is download-licenses-include-exclude-types maybe with the same root cause:
license-maven-plugin\target\it\download-licenses-include-exclude-types\target\generated-resources\licenses2\lgpl - lgpl-2.1.txt file is missing or a directory.

@Tibor17
Copy link
Contributor

Tibor17 commented Feb 2, 2019

@ppalaga
Here is the PR #225.

@ppalaga
Copy link
Contributor Author

ppalaga commented Feb 3, 2019

[WARNING] http://repository.jboss.org/licenses/cc0-1.0.txt [WARNING] connect timed out

repository.jboss.org was down. Saw the same failures in my branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants